Re: [PATCH] of: Check for phys_addr_t overflows in early_init_dt_add_memory_arch

[Geert Uytterhoeven]

Fixed Rob's and devicetree's addresses

On Thu, Jun 19, 2014 at 9:31 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> Hi Laura,
>
> On Thu, Jun 19, 2014 at 7:04 AM, Laura Abbott <lauraa@xxxxxxxxxxxxxx> wrote:
>> The common early_init_dt_add_memory_arch takes the base and size
>> of a memory region as u64 types. The function never checks if
>> the base and size can actually fit in a phys_addr_t which may
>> be smaller than 64-bits. This may result in incorrect memory
>> being passed to memblock_add if the memory falls outside the
>> range of phys_addr_t. Add range checks for the base and size if
>> phys_addr_t is smaller than u64.
>>
>> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> Signed-off-by: Laura Abbott <lauraa@xxxxxxxxxxxxxx>
>
> Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
>> ---
>> Geert, can you drop my other patch and give this a test to see if it fixes
>> your bootup problem?
>
> Thanks, works fine!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/