Re: [ANNOUNCE] 3.12.22-rt33

[Steven Rostedt]

On Thu, 19 Jun 2014 05:46:43 +0200
Mike Galbraith <umgwanakikbuti@xxxxxxxxx> wrote:

> On Wed, 2014-06-18 at 20:12 -0400, Steven Rostedt wrote: 
> > Dear RT Folks,
> > 
> > I'm pleased to announce the 3.12.22-rt33 stable release.

Didn't we have this issue before?

> 
> 
> git@marge:~/linux-2.6> git diff v3.12... drivers/net/ethernet/dec/tulip/tulip_core.c
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..a6d4653ebbc3 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1939,7 +1939,9 @@ static void tulip_remove_one(struct pci_dev *pdev)
>  	pci_iounmap(pdev, tp->base_addr);
>  	free_netdev (dev);
>  	pci_release_regions (pdev);
> +	pci_disable_device(pdev);
>  	pci_set_drvdata (pdev, NULL);
> +	pci_disable_device(pdev);
>  
>  	/* pci_power_off (pdev, -1); */
>  }
> 
> commit 4a77edc195f0b03644e84dda00fcfe9827868e8e
> Author: Ingo Molnar <mingo@xxxxxxx>
> Date:   Fri Jul 3 08:30:18 2009 -0500
> 
>     drivers/net: tulip_remove_one needs to call pci_disable_device()
>     
>     Otherwise the device is not completely shut down.

Grumble, this was a fix that went into -rt without going into stable
first.

OK, I'll remove this commit and keep the stable one.

Thanks!

-- Steve

>     
>     Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
>     Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> 
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..7565b994ec50 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
>  	pci_iounmap(pdev, tp->base_addr);
>  	free_netdev (dev);
>  	pci_release_regions (pdev);
> +	pci_disable_device(pdev);
>  	pci_set_drvdata (pdev, NULL);
>  
>  	/* pci_power_off (pdev, -1); */
> 
> 
> commit 831bb5573dcbeb0da783c82e21084ac191dafc24
> Author: Ingo Molnar <mingo@xxxxxxx>
> Date:   Fri Feb 14 15:32:20 2014 +0100
> 
>     drivers/net: tulip_remove_one needs to call pci_disable_device()
>     
>     commit c321f7d7c87cdc623c87845f6378620573e57512 upstream.
>     
>     Otherwise the device is not completely shut down.
>     
>     Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
>     Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>     Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>     Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
>     Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> 
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 4e8cfa2ac803..779016068a82 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1940,6 +1940,7 @@ static void tulip_remove_one(struct pci_dev *pdev)
>  	free_netdev (dev);
>  	pci_release_regions (pdev);
>  	pci_set_drvdata (pdev, NULL);
> +	pci_disable_device(pdev);

>  
>  	/* pci_power_off (pdev, -1); */
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/