Re: [PATCH] gpio: crystalcove: Fix implicit declaration of function 'seq_printf' error

[Alexandre Courbot]

On Fri, Jun 20, 2014 at 12:03 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> drivers/gpio/gpio-crystalcove.c: In function 'crystalcove_gpio_dbg_show':
> drivers/gpio/gpio-crystalcove.c:286:3: error: implicit declaration of function 'seq_printf'
>    seq_printf(s, " gpio-%-2d %s %s %s %s ctlo=%2x,%s %s %s\n",
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> I'm looking for a quick Ack on this patch.  It's a fix to an immutable
> branch that I'm carrying which is shared between GPIO and MFD.  Stephen
> reported it when the MFD tree was sucked into -next.
>
> Alexandre,
>   I believe Linus is out on vacation this week, so if you could take a
> quick look at this, I'd be much obliged.

Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx>

Hope that's fast enough. ;)

>
> Linus,
>   Once I've acquired the aforementioned Ack I'll fix this patch up into
> our immutable branch and send another pull-request.
> ---
>  drivers/gpio/gpio-crystalcove.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c
> index 5a98499..934462f 100644
> --- a/drivers/gpio/gpio-crystalcove.c
> +++ b/drivers/gpio/gpio-crystalcove.c
> @@ -18,6 +18,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/platform_device.h>
>  #include <linux/gpio.h>
> +#include <linux/seq_file.h>
>  #include <linux/bitops.h>
>  #include <linux/regmap.h>
>  #include <linux/mfd/intel_soc_pmic.h>
> --
> 1.8.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/