Re: [RFC/PATCH] perf tools: Fix segfault in cumulative.callchain report

[Arnaldo Carvalho de Melo]

Em Mon, Jun 16, 2014 at 10:14:22PM +0900, Namhyung Kim escreveu:
> 2014-06-15 (ì), 18:34 +0200, Jiri Olsa:
> > On Sun, Jun 15, 2014 at 09:46:31PM +0900, Namhyung Kim wrote:
> > > 2014-06-15 (ì), 10:35 +0200, Jiri Olsa:
> > > > not completely sure this is what we want to do, but have no
> > > > streght to dive into annotation code ;-)

> > > Currently, cumulative entries do not accounts annotation info so
> > > annotation only works for normal entries.  I'm not sure we should
> > > support it or not, but anyway it also needs some updates on the
> > > annotation code IMHO.

> > > So I'm okay with disabling annotation on pure cumulative entries.

> > is that an ack? ;-)

> Yep,
 
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

>From a quick look, this looks sane, i.e. only offering annotation for
symbols where samples were taken.

Otherwise we would have to figure out which samples came thru the
specific point in the callchain selected, which, as Namhyung mentioned,
requires more thinking and coding.

Acked-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/