Re: [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line

[josh]

On Thu, Jun 19, 2014 at 09:20:15PM +0200, Johannes Stadlinger wrote:
> This patch inserts a blank line after a declaration to avoid checkpatch
> warning.
> 
> Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@xxxxxx>
> Signed-off-by: Maximilian Eschenbacher <maximilian@xxxxxxxxxxxxxxxxxx>
> CC: linux-kernel@xxxxxxxxxxxx
> CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> CC: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> CC: Himangi Saraogi <himangi774@xxxxxxxxx>
> CC: Vitaly Osipov <vitaly.osipov@xxxxxxxxx>
> CC: devel@xxxxxxxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx

This is one case where I think checkpatch is just wrong; this doesn't
make the code any more (or less) readable.

Meh-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

>  drivers/staging/wlan-ng/prism2mgmt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index f90f7da..e6a82d3 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -190,6 +190,7 @@ int prism2mgmt_scan(wlandevice_t *wlandev, void *msgp)
>  	word = 0;
>  	for (i = 0; i < msg->channellist.data.len; i++) {
>  		u8 channel = msg->channellist.data.data[i];
> +
>  		if (channel > 14)
>  			continue;
>  		/* channel 1 is BIT 0 ... channel 14 is BIT 13 */
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/