Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc

[Joe Perches]

On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote:
> Hey Guys,
> So Sorry about wasting your time with bad patchs.
> I feel bad about that. I hope this patch is O.K.
> now. :(

Oh, one other thing...

> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
[]
> > @@ -36,7 +36,6 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
> >                              u32 buffer_len)
> >  {
> >         struct r8192_priv *priv = rtllib_priv(dev);
> > -       bool                rt_status = true;
> >         u16                 frag_threshold;
> >         u16                 frag_length, frag_offset = 0;
> >         int                 i;
[]
> > @@ -99,7 +100,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
> >
> >         write_nic_byte(dev, TPPoll, TPPoll_CQ);
> >
> > -       return rt_status;
> > +       return false;

This should be:

	return true;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/