Re: [PATCH 5/5] Staging: rtl8192u: r8192U_wx.c Removed commented dead code

From: Greg KH
Date: Thu Jun 19 2014 - 18:08:57 EST


On Thu, May 29, 2014 at 01:45:21PM -0700, Chaitanya Hazarey wrote:
> Removed dead code from the file.
>
> Signed-off-by: Chaitanya Hazarey <c@xxxxx>
> ---
> drivers/staging/rtl8192u/r8192U_wx.c | 18 +-----------------
> 1 file changed, 1 insertion(+), 17 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c
> index 09b1e81..ceb06d8 100644
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl8192u/r8192U_wx.c
> @@ -516,12 +516,9 @@ static int r8192_wx_set_enc(struct net_device *dev,
> struct r8192_priv *priv = ieee80211_priv(dev);
> struct ieee80211_device *ieee = priv->ieee80211;
> int ret;
> -
> - /* u32 TargetContent; */
> u32 hwkey[4] = {0, 0, 0, 0};
> u8 mask = 0xff;
> u32 key_idx = 0;
> - /* u8 broadcast_addr[6] ={ 0xff,0xff,0xff,0xff,0xff,0xff}; */
> u8 zero_addr[4][6] = { {0x00, 0x00, 0x00, 0x00, 0x00, 0x00},
> {0x00, 0x00, 0x00, 0x00, 0x00, 0x01},
> {0x00, 0x00, 0x00, 0x00, 0x00, 0x02},
> @@ -667,14 +664,6 @@ static int r8192_wx_set_retry(struct net_device *dev,
> */
>
> rtl8192_commit(dev);
> - /*
> - if(priv->up){
> - rtl8180_rtx_disable(dev);
> - rtl8180_rx_enable(dev);
> - rtl8180_tx_enable(dev);
> -
> - }
> - */
> exit:
> up(&priv->wx_sem);
>
> @@ -953,14 +942,9 @@ static const struct iw_priv_args r8192_private_args[] = {
>
>
> static iw_handler r8192_private_handler[] = {
> - /* r8192_wx_set_monitor, */ /* SIOCIWFIRSTPRIV */
> - r8192_wx_set_crcmon, /*SIOCIWSECONDPRIV*/
> - /* r8192_wx_set_forceassociate, */
> - /* r8192_wx_set_beaconinterval, */
> - /* r8192_wx_set_monitor_type, */
> + r8192_wx_set_crcmon,
> r8192_wx_set_scan_type,
> r8192_wx_set_rawtx,
> - /* r8192_wx_null, */
> r8192_wx_force_reset,
> };

This patch adds a checkpatch error, so I can't take it :(

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/