Re: [PATCH] ARM: tegra: TN7: relax some regulators
From: Mark Brown
Date: Fri Jun 20 2014 - 06:16:47 EST
On Fri, Jun 20, 2014 at 02:26:43PM +0900, Alexandre Courbot wrote:
> So I can see three questions here:
> 1) Why does _regulator_enable() on vdd_1v8 return 0 while everything
> suggests that it is enabled (this regulator powers lot of devices, like
> eMMC, which are working fine). This may be an issue with the palmas driver.
Returning 0 is reporting success and you say it is enabled so I'm not
seeing any contradiction here... or do you mean regulator_is_enabled()
here? An always on regulator should report that it is enabled.
> 2) When an always-on regulator that is not yet enabled is registered,
> shouldn't it be switched on by the regulator framework?
This happens during set_machine_constraints().
> 3) When a boot-on regulator is registered and _regulator_is_enabled()
> returns contradictory information, what should be done?
Same thing here (same check even).
Attachment:
signature.asc
Description: Digital signature