Re: [PATCH] staging:rtl8821ae: rewrite legacy wifi check in halbcoutsrc

From: Dan Carpenter
Date: Fri Jun 20 2014 - 15:59:36 EST


On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
> Rewrites the wireless check for legacy checking in function
> halbtc_legacy to check for both Mode A and B.

You're just guessing that A and B were intended but it could have been
something B and G...

Don't do this. Just leave the static checker warning there so someone
can fix it properly instead of introducing a second new bug and hiding
the warning so it's impossible to find.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/