Re: [PATCH] checkpatch.pl: Also suggest 'else if' when if follows brace

[Joe Perches]

On Fri, 2014-06-20 at 22:04 +0200, Rasmus Villemoes wrote:
> This might help a kernel hacker think twice before blindly adding a
> newline.

Sure, fine by me.

> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 010b18e..e1924eb 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3601,7 +3601,7 @@ sub process {
>  # if should not continue a brace
>  		if ($line =~ /}\s*if\b/) {
>  			ERROR("TRAILING_STATEMENTS",
> -			      "trailing statements should be on next line\n" .
> +			      "trailing statements should be on next line (or did you mean 'else if'?)\n" .
>  				$herecurr);
>  		}
>  # case and default should not have general statements after them



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/