Re: [PATCH] stagging: android: logger: code cleanup

From: Greg KH
Date: Sun Jun 22 2014 - 20:42:14 EST


On Sun, Jun 22, 2014 at 02:51:08PM -0400, Jerry Stralko wrote:
> Add the unlikey macro to the return value of nonseekable_open,
> since it always returns successfully.

That shouldn't be needed, gcc and the processor knows this already.
Don't use unusual unless you can measure it.

> Fixed up some checkpatch warnings.

Don't do more than one thing in a patch, please split this up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/