Re: [PATCH v2] ARM: mvebu: rename ARM_ERRATA_753970

[Russell King - ARM Linux]

It's nice to be ignored...

On Mon, Jun 23, 2014 at 11:01:44AM +0200, Paul Bolle wrote:
> ARM_ERRATA_753970 was renamed to PL310_ERRATA_753970 in v3.2, through
> commit fa0ce4035d48 ("ARM: 7162/1: errata: tidy up Kconfig options for
> PL310 errata workarounds"). Two selects were added in v3.15 that still
> use the previous name. Rename these.
> 
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> v2: redone on top of next-21040623, and therefor on top of commit
> a641f3a6abce ("ARM: l2c: fix dependencies on PL310 errata symbols").

And you obviously didn't read the commit or understand it.

> Dropped the "if CACHE_PL310" fragments used in v1. No need to use "if
> CACHE_L2X0" instead. Both CACHE_PL310 and CACHE_L2X0 will be
> (indirectly) selected if MACH_ARMADA_375 or MACH_ARMADA_38X are set.

Yes there is.  We've recently seen the selection of CACHE_L2X0 be removed
from platforms, while leaving the selection of the errata behind.  The
result is Kconfig warnings.  My commit above ensures that this doesn't
happen in the future by adding the proper dependencies onto those errata
selects.

Please do the same.

NAK.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/