Re: [PATCH 1/1] drivers/video/fbdev/sis/sis_main.c: remove unnecessary test on unsigned value

[Tomi Valkeinen]

On 11/06/14 22:54, Fabian Frederick wrote:
> unsigned value is never < 0
> 
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx>
> Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
>  drivers/video/fbdev/sis/sis_main.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 22ad028..3f12a2d 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -1572,10 +1572,6 @@ sisfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
>  	/* Adapt RGB settings */
>  	sisfb_bpp_to_var(ivideo, var);
>  
> -	/* Sanity check for offsets */
> -	if(var->xoffset < 0) var->xoffset = 0;
> -	if(var->yoffset < 0) var->yoffset = 0;
> -
>  	if(var->xres > var->xres_virtual)
>  		var->xres_virtual = var->xres;
>  
> 

Thanks, queued for 3.17.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature