RE: [patch 1/4] mm: vmscan: remove remains of kswapd-managed zone->all_unreclaimable

[Motohiro Kosaki]

> -----Original Message-----
> From: Minchan Kim [mailto:minchan@xxxxxxxxxx]
> Sent: Monday, June 23, 2014 2:16 AM
> To: Johannes Weiner
> Cc: Andrew Morton; Mel Gorman; Rik van Riel; Michal Hocko; linux-mm@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Motohiro Kosaki JP
> Subject: Re: [patch 1/4] mm: vmscan: remove remains of kswapd-managed zone->all_unreclaimable
> 
> On Fri, Jun 20, 2014 at 12:33:47PM -0400, Johannes Weiner wrote:
> > shrink_zones() has a special branch to skip the all_unreclaimable()
> > check during hibernation, because a frozen kswapd can't mark a zone
> > unreclaimable.
> >
> > But ever since 6e543d5780e3 ("mm: vmscan: fix do_try_to_free_pages()
> > livelock"), determining a zone to be unreclaimable is done by directly
> > looking at its scan history and no longer relies on kswapd setting the
> > per-zone flag.
> >
> > Remove this branch and let shrink_zones() check the reclaimability of
> > the target zones regardless of hibernation state.
> >
> > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
> 
> It would be not bad to Cced KOSAKI who was involved all_unreclaimable series several time with me.

Looks good to me.

KOSAKI Motohiro <Kosaki.motohiro@xxxxxxxxxxxxxx>