Re: [PATCH] mmc: sdhci-pci: Quark SDIO host controller supporting

[Bjorn Helgaas]

On Fri, Jun 20, 2014 at 10:13 AM, Chen, Alvin <alvin.chen@xxxxxxxxx> wrote:
> From: Derek Browne <Derek.Browne@xxxxxxxxx>
>
> On Intel Quark, there is a SDIO host controller. This patch is added to
> enable the SDIO host controller.
>
> Signed-off-by: Derek Browne <Derek.Browne@xxxxxxxxx>
> Signed-off-by: Alvin (Weike) Chen <alvin.chen@xxxxxxxxx>
> ---
>  drivers/mmc/host/sdhci-pci.c |   12 ++++++++++++
>  include/linux/pci_ids.h      |    2 ++

Please read the comment at the top of pci_ids.h:

 *      Do not add new entries to this file unless the definitions
 *      are shared between multiple drivers.

If the ID you're adding is shared, please mention the sharing in your changelog.

> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2557,6 +2557,7 @@
>  #define PCI_DEVICE_ID_INTEL_MFD_EMMC0  0x0823
>  #define PCI_DEVICE_ID_INTEL_MFD_EMMC1  0x0824
>  #define PCI_DEVICE_ID_INTEL_MRST_SD2   0x084F
> +#define PCI_DEVICE_ID_INTEL_QUARK_ILB  0x095E

This ID doesn't appear to be used at all.

>  #define PCI_DEVICE_ID_INTEL_I960       0x0960
>  #define PCI_DEVICE_ID_INTEL_I960RM     0x0962
>  #define PCI_DEVICE_ID_INTEL_CENTERTON_ILB      0x0c60
> @@ -2579,6 +2580,7 @@
>  #define PCI_DEVICE_ID_INTEL_82840_HB   0x1a21
>  #define PCI_DEVICE_ID_INTEL_82845_HB   0x1a30
>  #define PCI_DEVICE_ID_INTEL_IOAT       0x1a38
> +#define PCI_DEVICE_ID_INTEL_QRK_SD     0x08A7
>  #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN        0x1c41
>  #define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MAX        0x1c5f
>  #define PCI_DEVICE_ID_INTEL_PATSBURG_LPC_0     0x1d40
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/