Re: [PATCH V2 08/22] amd: Use pci_zalloc_consistent

From: Don Fry
Date: Mon Jun 23 2014 - 18:31:47 EST


On Mon, 2014-06-23 at 14:05 -0700, Joe Perches wrote:
> Remove the now unnecessary memset too.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> On Mon, 2014-06-23 at 12:15 -0700, Joe Perches wrote:
> > On Mon, 2014-06-23 at 11:02 -0700, Don Fry wrote:
> > > This causes the line length to be greater than 80 characters causing
> > > checkpatch to complain.
>
> V2: Don Fry is an 80 column neatnik.
>
> Please remember this depends on patch 1/22 being applied
> before this patch can be successfully applied.
>
> drivers/net/ethernet/amd/pcnet32.c | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c
> index e7cc917..8099fdc 100644
> --- a/drivers/net/ethernet/amd/pcnet32.c
> +++ b/drivers/net/ethernet/amd/pcnet32.c
> @@ -484,15 +484,14 @@ static void pcnet32_realloc_tx_ring(struct net_device *dev,
>
> pcnet32_purge_tx_ring(dev);
>
> - new_tx_ring = pci_alloc_consistent(lp->pci_dev,
> - sizeof(struct pcnet32_tx_head) *
> - (1 << size),
> - &new_ring_dma_addr);

Acked-By: Don Fry <pcnet32@xxxxxxxxxxxx>

>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/