Re: [PATCH v8 4/4] printk: allow increasing the ring buffer depending on the number of CPUs

[Andrew Morton]

On Wed, 18 Jun 2014 13:45:37 -0700 "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx> wrote:

> ...
>
> If an increase is required the ring buffer is increased to
> +	  the next power of 2 that can fit both the minimum kernel ring buffer
> +	  (LOG_BUF_SHIFT) plus the additional worst case CPU contributions.
>
> ...
>
> +	log_buf_len_update(cpu_extra + __LOG_BUF_LEN);
> +}

I'd have expected

  total_cpu_space = minimum-per-cpu-len * nr_possible_cpus;
  log_buf_len = max(__LOG_BUF_LEN, total_cpu_space)

but here you added __LOG_BUF_LEN to total_cpu_space and I cannot work
out why.  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/