RE: [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface

[Ren, Qiaowei]

On 2014-06-24, Andy Lutomirski wrote:
>> +	/* Make bounds tables and bouds directory unlocked. */
>> +	if (vm_flags & VM_LOCKED)
>> +		vm_flags &= ~VM_LOCKED;
> 
> Why?  I would expect MCL_FUTURE to lock these.
> 
Andy, I was just a little confused about LOCKED & POPULATE earlier and I thought VM_LOCKED is not necessary for MPX specific bounds tables. Now, this checking should be removed, and there should be mm_populate() for VM_LOCKED case after mmap_region():

   if (!IS_ERR_VALUE(addr) && (vm_flags & VM_LOCKED))
       mm_populate(addr, len);

Thanks,
Qiaowei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/