Re: [PATCH v3 1/5] apei, mce: Factor out APEI architecture specific MCE calls.

[Tomasz Nowicki]

On 19.06.2014 16:17, Borislav Petkov wrote:
> On Fri, Jun 13, 2014 at 01:02:56PM +0200, Tomasz Nowicki wrote:
> > This commit abstracts MCE calls and provides weak corresponding default
> > implementation for those architectures which do not need arch specific
> > actions. Each platform willing to do additional architectural actions
> > should provides desired function definition. It allows us to avoid wrap
> > code into #ifdef in generic code and prevent new platform from introducing
> > dummy stub function too.
> >
> > Initially, there are two APEI arch-specific calls:
> > - apei_arch_enable_cmcff()
> > - apei_arch_report_mem_error()
> > Both interact with MCE driver for X86 architecture.
> >
> > Signed-off-by: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx>
>
> ...
>
> > diff --git a/arch/x86/kernel/acpi/apei.c b/arch/x86/kernel/acpi/apei.c
> > new file mode 100644
> > index 0000000..dca2852
> > --- /dev/null
> > +++ b/arch/x86/kernel/acpi/apei.c
> > @@ -0,0 +1,56 @@
> > +/*
> > + * Arch-specific APEI-related functions.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#include <acpi/apei.h>
> > +
> > +#include <asm/mce.h>
> > +
> > +int apei_arch_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data)
>
> Arch-specific function names usually use the "arch_" prefix. Otherwise
> it looks ok.

True, will fix that.

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/