Re: [PATCH] sched/idle: Drop !! while calculating 'broadcast'
From: Mike Galbraith
Date: Tue Jun 24 2014 - 08:18:13 EST
On Tue, 2014-06-24 at 10:03 +0200, Peter Zijlstra wrote:
> On Tue, Jun 24, 2014 at 10:01:01AM +0530, Viresh Kumar wrote:
> > We don't need 'broadcast' to be set to 'zero or one', but to 'zero or non-zero'
> > and so the extra operation to convert it to 'zero or one' can be skipped.
> >
> > Also change type of 'broadcast' to unsigned int, i.e. type of
> > drv->states[*].flags.
>
> All true; but does it change anything? That is, does your compiler
> generate better code because of this?
x86_64 gcc-4.8.3 made 1 less instruction, a shift.
-Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/