Re: [PATCH v3 06/13] mm, compaction: periodically drop lock and restore IRQs in scanners

[Vlastimil Babka]

On 06/24/2014 05:39 PM, Naoya Horiguchi wrote:
> On Fri, Jun 20, 2014 at 05:49:36PM +0200, Vlastimil Babka wrote:
> > Compaction scanners regularly check for lock contention and need_resched()
> > through the compact_checklock_irqsave() function. However, if there is no
> > contention, the lock can be held and IRQ disabled for potentially long time.
> >
> > This has been addressed by commit b2eef8c0d0 ("mm: compaction: minimise the
> > time IRQs are disabled while isolating pages for migration") for the migration
> > scanner. However, the refactoring done by commit 748446bb6b ("mm: compaction:
> > acquire the zone->lru_lock as late as possible") has changed the conditions so
>
> You seem to refer to the incorrect commit, maybe you meant commit 2a1402aa044b?

Oops, right. Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/