Re: [PATCH v8] NVMe: convert to blk-mq

[Keith Busch]

On Tue, 24 Jun 2014, Matias BjÃrling wrote:
> On Tue, Jun 24, 2014 at 10:33 PM, Keith Busch <keith.busch@xxxxxxxxx> wrote:
> > On Tue, 24 Jun 2014, Matias Bjorling wrote:
> > > Den 16-06-2014 17:57, Keith Busch skrev:
> > > > This latest is otherwise stable on my dev machine.
> > >
> > > May I add an Acked-by from you?
> >
> > Totally up to Willy, but my feeling is "not just yet". I see the value
> > this driver provides, but I would need to give this to a customer and
> > hear their results before adding an "ack". It maybe a couple more weeks
> > before they'll be able to try it.
>
> I was hoping to get an OK before that, to make sure it is picked up
> for the 3.17 release.
>
> Should I pack it up in a specific way to help it along?

I think what you're doing is the right way to go. I trust you removed
the test code from your next iteration, and this does pass my tests on my
machine... I was just hoping to hear what some other people with better
macro level benchmarking abilities would say. So okay, you can put my
"Acked-by" on this, but I don't have all the performance numbers yet.