Re: [PATCH v2] pinctrl: msm: Add msm8960 definitions

From: Andreas Färber
Date: Tue Jun 24 2014 - 20:17:53 EST


Am 24.06.2014 20:16, schrieb Bjorn Andersson:
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt
> new file mode 100644
> index 0000000..6e79eea
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8960-pinctrl.txt
[...]
> +Example:
> +
> + msmgpio: pinctrl@800000 {
> + compatible = "qcom,msm8960-pinctrl";
> + reg = <0x800000 0x4000>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <0 32 0x4>;

This line seems space-indented while surrounding ones are tab-indented.

> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&debug_uart>;
> +
> + debug_uart: debug_uart {

While at it, might debug-uart be a better node name? That seems the
predominant convention and distinguishes from the label.

Regards,
Andreas

> + mux {
> + pins = "gpio34", "gpio35";
> + function = "gsbi8";
> + };
> +
> + tx {
> + pins = "gpio34";
> + drive-strength = <4>;
> + bias-disable;
> + };
> +
> + rx {
> + pins = "gpio35";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> + };
> + };
[snip]

--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/