Re: [PATCH -mm 2/3] page-cgroup: get rid of NR_PCG_FLAGS

[Michal Hocko]

On Tue 24-06-14 20:33:05, Vladimir Davydov wrote:
> It's not used anywhere today, so let's remove it.
> 
> Signed-off-by: Vladimir Davydov <vdavydov@xxxxxxxxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxx>

> ---
>  include/linux/page_cgroup.h |    6 ------
>  kernel/bounds.c             |    2 --
>  2 files changed, 8 deletions(-)
> 
> diff --git a/include/linux/page_cgroup.h b/include/linux/page_cgroup.h
> index 23863edb95ff..fb60e4a466c0 100644
> --- a/include/linux/page_cgroup.h
> +++ b/include/linux/page_cgroup.h
> @@ -6,12 +6,8 @@ enum {
>  	PCG_USED,	/* This page is charged to a memcg */
>  	PCG_MEM,	/* This page holds a memory charge */
>  	PCG_MEMSW,	/* This page holds a memory+swap charge */
> -	__NR_PCG_FLAGS,
>  };
>  
> -#ifndef __GENERATING_BOUNDS_H
> -#include <generated/bounds.h>
> -
>  struct pglist_data;
>  
>  #ifdef CONFIG_MEMCG
> @@ -107,6 +103,4 @@ static inline void swap_cgroup_swapoff(int type)
>  
>  #endif /* CONFIG_MEMCG_SWAP */
>  
> -#endif /* !__GENERATING_BOUNDS_H */
> -
>  #endif /* __LINUX_PAGE_CGROUP_H */
> diff --git a/kernel/bounds.c b/kernel/bounds.c
> index 9fd4246b04b8..e1d1d1952bfa 100644
> --- a/kernel/bounds.c
> +++ b/kernel/bounds.c
> @@ -9,7 +9,6 @@
>  #include <linux/page-flags.h>
>  #include <linux/mmzone.h>
>  #include <linux/kbuild.h>
> -#include <linux/page_cgroup.h>
>  #include <linux/log2.h>
>  #include <linux/spinlock_types.h>
>  
> @@ -18,7 +17,6 @@ void foo(void)
>  	/* The enum constants to put into include/generated/bounds.h */
>  	DEFINE(NR_PAGEFLAGS, __NR_PAGEFLAGS);
>  	DEFINE(MAX_NR_ZONES, __MAX_NR_ZONES);
> -	DEFINE(NR_PCG_FLAGS, __NR_PCG_FLAGS);
>  #ifdef CONFIG_SMP
>  	DEFINE(NR_CPUS_BITS, ilog2(CONFIG_NR_CPUS));
>  #endif
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/