Re: [PATCH] scripts/checkpatch.pl: Only emit LONG_LINE for --strict
From: Josh Triplett
Date: Wed Jun 25 2014 - 23:45:07 EST
On Wed, Jun 25, 2014 at 07:33:03PM -0700, Joe Perches wrote:
> On Wed, 2014-06-25 at 19:24 -0700, Josh Triplett wrote:
> > On Wed, Jun 25, 2014 at 05:05:07PM -0700, Joe Perches wrote:
> > > On Wed, 2014-06-25 at 08:46 -0700, Josh Triplett wrote:
> > > > Regardless of the long-standing debate over line width, checkpatch
> > > > should not warn about it by default.
> > >
> > > I'm not getting involved here.
> > > I don't care much one way or another.
> []
> > I'm not asking you to get involved in the Great Line Length Debate;
> > that's why I didn't attempt to patch CodingStyle or similar. However, I
> > think it makes sense for *checkpatch* to stop emitting this warning.
>
> I think checkpatch should encourage people to write code in
> a style that matches CodingStyle as well as the predominant
> styles used in the rest of the kernel.
Not arguing with that, but in this particular case the warning seems
counterproductive to that goal, especially compared to the
DEEP_INDENTATION warning. More subjective or "to taste" issues tend
to have lower severity in checkpatch. And CodingStyle *already* says
"unless exceeding 80 columns significantly increases
readability"
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/