Re: [PATCH] scripts/checkpatch.pl: Only emit LONG_LINE for --strict
From: Greg KH
Date: Thu Jun 26 2014 - 00:00:23 EST
On Wed, Jun 25, 2014 at 07:24:49PM -0700, Josh Triplett wrote:
> On Wed, Jun 25, 2014 at 05:05:07PM -0700, Joe Perches wrote:
> > On Wed, 2014-06-25 at 08:46 -0700, Josh Triplett wrote:
> > > Regardless of the long-standing debate over line width, checkpatch
> > > should not warn about it by default.
> >
> > I'm not getting involved here.
> >
> > I don't care much one way or another.
> >
> > I did submit a patch where I ignored 80
> > columns recently and I was told to try
> > again by the maintainer.
>
> I'm not asking you to get involved in the Great Line Length Debate;
> that's why I didn't attempt to patch CodingStyle or similar. However, I
> think it makes sense for *checkpatch* to stop emitting this warning.
>
> I'm hoping that Greg will chime in, as the maintainer of staging and the
> recipient of a huge number of checkpatch-motivated patches.
I have no problem with the existing checkpatch.pl tool and it calling
out 80 columns as a problem that needs to be fixed. So I don't like
this patch at all.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/