Re: [PATCH] of: Transactional DT support.

From: Grant Likely
Date: Thu Jun 26 2014 - 02:56:42 EST


On Wed, 25 Jun 2014 12:20:16 -0700, Dan Malek <dan.malek@xxxxxxxxxxxx> wrote:
>
> On Jun 25, 2014, at 7:48 AM, Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx> wrote:
>
> >>> +int of_transaction_commit(struct of_transaction *oft);
> >>
> >> How about of_transaction_apply()?
> >>
> >
> > Sure.
>
> LOL! Panto, you give in too easily :)
>
> Any transaction state diagrams I've seen always have a "commit" phase/state, never anything called "apply." So, of_transaction_commit() is exactly the proper name.

Hahaha. my suggestiong on name is conditional on my earlier comment to
make the API bulk-change instead of transaction oriented. Commit is
indeed the right name for a transactional model.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/