Re: [PATCH] cxgb4: use dev_port to identify ports

[Thadeu Lima de Souza Cascardo]

On Wed, Jun 25, 2014 at 04:08:21PM -0700, Luis R. Rodriguez wrote:
> On Sat, Jun 21, 2014 at 5:48 AM, Thadeu Lima de Souza Cascardo
> <cascardo@xxxxxxxxxxxxxxxxxx> wrote:
> > That use was removed by commit
> > 8c367fcbe6549195d2eb11e62bea233f811aad41 ("cxgb4: Do not set
> > net_device::dev_id to VI index"), since dev_id should be used only when
> > devices share the same MAC address.
> >
> > Using dev_port for cxgb4 allows different ports on the same PCI function
> > to be identified.
> 
> Can you describe what issues were introduced because of this then?
> 
>   Luis
> 

udevd builtin net-id cannot rename the interfaces, since it relies on
the dev_id for interfaces on the same PCI function. I am going to send a
patch to use dev_port instead, and fallback to dev_id, and copy netdev.

Regards.
Cascardo.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/