Re: [PATCH] i2c: cros_ec: Remove EC_I2C_FLAG_10BIT
From: Wolfram Sang
Date: Fri Jun 27 2014 - 08:34:57 EST
On Mon, Jun 23, 2014 at 02:20:06PM -0700, Doug Anderson wrote:
> In <https://lkml.org/lkml/2014/6/10/265> pointed out that the 10-bit
> flag in the cros_ec_tunnel was useless. It went into a 16-bit flags
> field but was defined at (1 << 16).
>
> Since we have no 10-bit i2c devices on the other side of the tunnel on
> any known devices this was never a problem. Until we do it makes
> sense to remove this code. On the EC side the code to handle this
> flag was removed in <https://chromium-review.googlesource.com/204162>.
>
> Reported-by: Dave Jones <davej@xxxxxxxxxx>
> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> ---
> Note that this patch is based atop my current series of posts to
> cleanup cros_ec. It wouldn't be hard to apply it to the current ToT
> if someone wants to land this before the others.
I could take it into my tree, but I think it makes more sense if we
simply append it to your cleanup series?
Reviewed-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
Attachment:
signature.asc
Description: Digital signature