Re: [PATCH v6 1/6] KEYS: special dot prefixed keyring name bug fix

From: David Howells
Date: Fri Jun 27 2014 - 09:24:42 EST


Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote:

> Dot prefixed keyring names are supposed to be reserved for the
> kernel, but add_key() calls key_get_type_from_user(), which
> incorrectly verifies the 'type' field, not the 'description' field.
> This patch verifies the 'description' field isn't dot prefixed,
> when creating a new keyring, and removes the dot prefix test in
> key_get_type_from_user().
>
> Changelog v6:
> - whitespace and other cleanup
>
> Changelog v5:
> - Only prevent userspace from creating a dot prefixed keyring, not
> regular keys - Dmitry
>
> Reported-by: Dmitry Kasatkin <d.kasatkin@xxxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx>

Acked-by: David Howells <dhowells@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/