Re: [PATCH v2 1/1] staging: iio: ad9850.c: fix checkpatch.pl error

From: Guillaume Morin
Date: Fri Jun 27 2014 - 22:30:33 EST


On 27 Jun 19:09, Greg Kroah-Hartman wrote:
> > v2: add missing Signed-off-by
>
> That doesn't go here.

I guess I am struggling to get git send-email do what I want

> And what checkpatch error did you fix? And are you sure it needs to be
> fixed?

That's what I changed:

$ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c
ERROR: Macros with complex values should be enclosed in parenthesis
#24: FILE: drivers/staging/iio/frequency/ad9850.c:24:
+#define value_mask (u16)0xf000

I assumed that if it was reported as an error, it needed to be fixed...

--
Guillaume Morin <guillaume@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/