Re: [PATCH 3/4] DRBG: Fix format string for debugging statements

[Stephan Mueller]

Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell:

Hi Stephen,

> Hi Stephan,
> 
> On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller <smueller@xxxxxxxxxx> 
wrote:
> > @@ -1987,8 +1987,9 @@ static int __init drbg_init(void)
> > 
> >  	if (ARRAY_SIZE(drbg_cores) * 2 > ARRAY_SIZE(drbg_algs)) {
> >  	
> >  		pr_info("DRBG: Cannot register all DRBG types"
> > 
> > -			"(slots needed: %lu, slots available: %lu)\n",
> > -			ARRAY_SIZE(drbg_cores) * 2, ARRAY_SIZE(drbg_algs));
> > +			"(slots needed: %u, slots available: %u)\n",
> > +			(unsigned int)ARRAY_SIZE(drbg_cores) * 2,
> > +			(unsigned int)ARRAY_SIZE(drbg_algs));
> 
> Doesn't ARRAY_SIZE() always return a size_t?  In which case surely we
> need no casts, but need to us %zu in the format string.

Unfortunately not at all. On my x86_64, I get the compiler warning that 
ARRAY_SIZE is a long unsigned int without the cast.

Ciao
Stephan
-- 
| Cui bono? |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/