RE: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before kfree

[Varun Sethi]

> -----Original Message-----
> From: iommu-bounces@xxxxxxxxxxxxxxxxxxxxxxxxxx [mailto:iommu-
> bounces@xxxxxxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Fabian Frederick
> Sent: Sunday, June 29, 2014 1:31 PM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Fabian Frederick; Grant Likely; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Subject: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before
> kfree
> 
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
> 
> Cc: Joerg Roedel <joro@xxxxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxx>
> Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
>  drivers/iommu/fsl_pamu_domain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/fsl_pamu_domain.c
> b/drivers/iommu/fsl_pamu_domain.c index 93072ba..0009dff 100644
> --- a/drivers/iommu/fsl_pamu_domain.c
> +++ b/drivers/iommu/fsl_pamu_domain.c
> @@ -1118,8 +1118,7 @@ static int fsl_pamu_set_windows(struct iommu_domain
> *domain, u32 w_count)
>  	ret = pamu_set_domain_geometry(dma_domain, &domain->geometry,
>  				((w_count > 1) ? w_count : 0));
>  	if (!ret) {
> -		if (dma_domain->win_arr)
> -			kfree(dma_domain->win_arr);
> +		kfree(dma_domain->win_arr);
>  		dma_domain->win_arr = kzalloc(sizeof(struct dma_window) *
>  							  w_count, GFP_ATOMIC);
>  		if (!dma_domain->win_arr) {

Acked-by: Varun Sethi <varun.sethi@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/