RE: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

[David Laight]

From: Richard Leitner 
> On Mon, 30 Jun 2014 08:41:18 +0000
> David Laight <David.Laight@xxxxxxxxxx> wrote:
> 
> > From: Of Richard Leitner
> > > Replaces all hardcoded ttyGS strings with the PREFIX macro.
> > > Due to the fact the strings are spread over different source files the
> > > PREFIX definition is moved to u_serial.h
> >
> > Lots of changes like:
> > > -		DBG(cdev, "acm ttyGS%d completion, err %d\n",
> > > -				acm->port_num, req->status);
> > > +		DBG(cdev, "acm %s%d completion, err %d\n",
> > > +				PREFIX, acm->port_num, req->status);
> >
> > I'm not sure this improves the code.
> 
> Maybe you're right, the readability of the code wouldn't be better afterwards,
...

Indeed it will make most attempts to grep for the error message fail.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/