Re: [PATCH 6/9 v2] coresight-etm: add CoreSight ETM/PTM driver

[Mathieu Poirier]

On 30 June 2014 05:01, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote:
> On 27.06.2014 20:04, mathieu.poirier@xxxxxxxxxx wrote:
>>
>> From: Pratik Patel <pratikp@xxxxxxxxxxxxxx>
>>
>> This driver manages CoreSight ETM (Embedded Trace Macrocell) that
>> supports processor tracing. Currently supported version are ARM
>> ETMv3.3, v3.5 and PTM.
>>
>> Signed-off-by: Pratik Patel <pratikp@xxxxxxxxxxxxxx>
>> Panchaxari Prasannamurthy <panchaxari.prasannamurthy@xxxxxxxxxx>
>> Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
>> ---
>>   arch/arm/include/asm/hardware/cp14.h   |  540 ++++++++++++
>>   drivers/coresight/Kconfig              |   19 +
>>   drivers/coresight/Makefile             |    1 +
>>   drivers/coresight/coresight-etm-cp14.c |  506 +++++++++++
>>   drivers/coresight/coresight-etm.c      | 1507
>> ++++++++++++++++++++++++++++++++
>>   drivers/coresight/coresight-etm.h      |  192 ++++
>>   6 files changed, 2765 insertions(+)
>>   create mode 100644 arch/arm/include/asm/hardware/cp14.h
>>   create mode 100644 drivers/coresight/coresight-etm-cp14.c
>>   create mode 100644 drivers/coresight/coresight-etm.c
>>   create mode 100644 drivers/coresight/coresight-etm.h
>
> ....
>>
>> diff --git a/drivers/coresight/coresight-etm-cp14.c
>> b/drivers/coresight/coresight-etm-cp14.c
>> new file mode 100644
>> index 0000000..4173710
>> --- /dev/null
>> +++ b/drivers/coresight/coresight-etm-cp14.c
>> @@ -0,0 +1,506 @@
>> +/* Copyright (c) 2012, The Linux Foundation. All rights reserved.
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 and
>> + * only version 2 as published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/types.h>
>> +#include <linux/bug.h>
>> +#include <asm/hardware/cp14.h>
>> +
>> +#include <coresight-etm.h>
>
>
> As coresight-etm.h is in drivers/coresight I had to use
>
> -#include <coresight-etm.h>
> +#include "coresight-etm.h"
>
> Not sure if this somehow depends on the kernel version/tooling, though.

You mean that you got a compilation failure?

>
> Best regards
>
> Dirk
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/