Re: [RFC 1/1] proc: constify seq_operations

From: Andrew Morton
Date: Mon Jun 30 2014 - 16:39:46 EST


On Mon, 30 Jun 2014 21:03:17 +0200 Fabian Frederick <fabf@xxxxxxxxx> wrote:

> proc_uid_seq_operations, proc_gid_seq_operations and proc_projid_seq_operations
> are only called in proc_id_map_open with seq_open as
> const struct seq_operations so we can constify the 3 structures and update
> proc_id_map_open prototype.

There are an absolutely enormous number of places where we could
constify things. For sheer sanity's sake I'm not inclined to churn the
code in this way unless a patch provides some sort of runtime benefit.
And this particular patch doesn't appear to change the generated code
at all.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/