Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier

From: Mark Brown
Date: Mon Jun 30 2014 - 17:44:09 EST


On Mon, Jun 30, 2014 at 06:21:15PM +0100, Mark Rutland wrote:
> On Mon, Jun 30, 2014 at 06:10:59PM +0100, Dan Murphy wrote:

> > +Optional properties:

> > +- power-gpio - gpio pin to enable/disable the device

> The code below seems to look for "enable-gpio". Searching for
> "power-gpio" only hits in the line above and the example below. I assume
> the code is in error?

It depends what this is for - if it's for an external regulator it
should be a regulator binding. Also all GPIO properties
are supposed to be called -gpios because DT conventions.

Attachment: signature.asc
Description: Digital signature