Re: [PATCH] x86: ioapic: Fix irq_free_descs count

[David Rientjes]

On Mon, 30 Jun 2014, Keith Busch wrote:

> Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

This is definitely a fix for "genirq: Provide generic hwirq allocation 
facility", but the changelog doesn't describe what the problem is and the 
title that this somehow fixes irq_free_descs() doesn't make any sense.

It's the equivalent of just doing

-	irq_free_descs(from, cnt);
+	irq_free_descs(from, i - from);

I'd suggest the patch title be changed to

	genirq: Fix memory leak when calling irq_free_hwirqs()

and the changelog state

irq_free_hwirqs() always calls irq_free_descs() with a cnt == 0 which 
makes it a no-op since the interrupt count to free is decremented in 
itself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/