Re: [PATCH 05/33] ARM: at91/dt: rm9200: define clocks

[Boris BREZILLON]

Hello Alexandre,

On Tue,  1 Jul 2014 16:12:14 +0200
Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote:

> Signed-off-by: Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxxxxxxxxx> ---
>  arch/arm/boot/dts/at91rm9200.dtsi | 304
> ++++++++++++++++++++++++++++++++++++++ 1 file changed, 304
> insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91rm9200.dtsi
> b/arch/arm/boot/dts/at91rm9200.dtsi index c61b16fba79b..477cfe570f47
> 100644 --- a/arch/arm/boot/dts/at91rm9200.dtsi
> +++ b/arch/arm/boot/dts/at91rm9200.dtsi
> @@ -14,6 +14,7 @@
>  #include <dt-bindings/pinctrl/at91.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/clock/at91.h>
>  
>  / {
>  	model = "Atmel AT91RM9200 family SoC";
> @@ -51,6 +52,20 @@
>  		reg = <0x20000000 0x04000000>;
>  	};
>  
> +	clocks {

[...]

> +
> +					tcb0_clk: tcb0_clk {
> +						#clock-cells = <0>;
> +						reg = <17>;
> +					};
> +
> +					tcb1_clk: tcb1_clk {
> +						#clock-cells = <0>;
> +						reg = <18>;
> +					};
> +
> +					tcb2_clk: tcb2_clk {
> +						#clock-cells = <0>;
> +						reg = <19>;
> +					};
> +
> +					tcb3_clk: tcb3_clk {
> +						#clock-cells = <0>;
> +						reg = <20>;
> +					};
> +
> +					tcb4_clk: tcb4_clk {
> +						#clock-cells = <0>;
> +						reg = <21>;
> +					};
> +
> +					tcb5_clk: tcb5_clk {
> +						#clock-cells = <0>;
> +						reg = <22>;
> +					};

Just a nitpick, but the names defined in at91rm9200.c and in the
datasheet are tcX_clk and not tcbX_clk.

Best Regards,

Boris



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/