Re: [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set

From: Boris BREZILLON
Date: Wed Jul 02 2014 - 04:18:25 EST


On Tue, 1 Jul 2014 16:12:12 +0200
Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote:

> When the main crystal frequency is not set, the main clock is
> approximated using the MAINF value in the CKGR_MCFR register. Warn
> the user in that case.
>
> Signed-off-by: Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxxxxxxxxx> ---

Acked-by: Boris BREZILLON <boris.brezillon@xxxxxxxxxxx>

Mike, do you want me to take this patch and send you a pull request, or
should I let you take this one directly ?

Best Regards,

Boris

> drivers/clk/at91/clk-main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c
> index 733306131b99..59fa3cc96c9e 100644
> --- a/drivers/clk/at91/clk-main.c
> +++ b/drivers/clk/at91/clk-main.c
> @@ -388,6 +388,7 @@ static unsigned long clk_main_recalc_rate(struct
> at91_pmc *pmc, if (parent_rate)
> return parent_rate;
>
> + pr_warn("Main crystal frequency not set, using approximate
> value\n"); tmp = pmc_read(pmc, AT91_CKGR_MCFR);
> if (!(tmp & AT91_PMC_MAINRDY))
> return 0;



--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/