RE: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

[Varun Sethi]

Thanks Emil.

> -----Original Message-----
> From: Emil Medve [mailto:Emilian.Medve@xxxxxxxxxxxxx]
> Sent: Wednesday, July 02, 2014 1:16 PM
> To: Sethi Varun-B16395; iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx;
> joro@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linuxppc-
> dev@xxxxxxxxxxxxxxxx; alex.williamson@xxxxxxxxxx
> Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
> 
> On 06/24/2014 08:57 AM, Varun Sethi wrote:
> > is_power_of_2 requires an unsigned long parameter which would lead to
> > truncation of 64 bit values on 32 bit architectures.
> >
> > __ffs also expects an unsigned long parameter thus won't work for 64
> > bit values on 32 bit architectures.
> >
> > Signed-off-by: Varun Sethi <Varun.Sethi@xxxxxxxxxxxxx>
> > ---
> >  drivers/iommu/fsl_pamu.c        |    8 ++++----
> >  drivers/iommu/fsl_pamu_domain.c |    2 +-
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> Tested-by: Emil Medve <Emilian.Medve@xxxxxxxxxxxxx>
> 
> On a P4080 DS (i.e. 32-bit SoC)
> 
> 
> Cheers,