Re: [PATCH 49/50] mars: generic pre-patch for mars

[Christoph Hellwig]

On Wed, Jul 02, 2014 at 01:24:00AM -0700, Greg KH wrote:
> > I will prepare a new version ASAP.
> > 
> > Is the asmlinkage one of the reasons?
> 
> No.  The wholesale exporting of all 300+ syscall functions for no
> apparent reasoning is the reason.

Using syscalls or syscall-like functionality from kernel code generally
is a bad idea.  Every single use needs a clear rationale in the patch
description.  Which do not seem to exist at all for the series, so in
it's current form it'll go straight to the trash bin anyway.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/