Re: [PATCH v2 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups

From: Ian Abbott
Date: Thu Jul 03 2014 - 05:39:24 EST


On 2014-07-03 03:15, Chase Southwood wrote:
This patchset moves a misplaced include to the proper file, swaps out an overly
aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().

Chase Southwood (3):
staging: comedi: addi_apci_1564: move addi_watchdog.h include to
addi_apci_1564.c
staging: comedi: addi_apci_1564: fix use of apci1564_reset() to
disable DI interrupts
staging: comedi: addi_apci_1564: clean up apci1564_interrupt()

.../comedi/drivers/addi-data/hwdrv_apci1564.c | 2 -
drivers/staging/comedi/drivers/addi_apci_1564.c | 139 +++++----------------
2 files changed, 32 insertions(+), 109 deletions(-)


Looks good! You didn't list the v2 changes though. Maybe you could summarize them here?

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/