Re: [PATCH 3/6] lib80211: re-use string_escape_mem_any_np()

[Andy Shevchenko]

On Wed, 2014-07-02 at 09:30 -0700, Joe Perches wrote:
> On Wed, 2014-07-02 at 17:06 +0300, Andy Shevchenko wrote:
> > On Wed, 2014-07-02 at 06:43 -0700, Joe Perches wrote:
> > > On Wed, 2014-07-02 at 16:20 +0300, Andy Shevchenko wrote:
> > > > In kernel we have function to escape a given string. Let's use it instead of
> > > > custom approach.
> > > > 
> > > > This fixes a bug. The current implementation wrongly prints octal numbers: only
> > > > two first digits are used in case when 3 are required and the rest of the
> > > > string ends up cut off.
> > 
> > []
> > 
> > > This code looks like it was adapted from the old print_mac
> > > ethernet code that was eventually replaced by a vsprintf
> > > pointer extension %pM
> > > 
> > > So a better way to do this might be to add and use yet
> > > another vsprintf %p<foo> extension for ssids.
> > 
> > Might be, but it
> >  - doesn't reduce necessity of string_escape_mem (not only ssid are
> > escaped in kernel)
> >  - prevents user to choose a rule what exactly their would like to
> > escape (look at the other patches against ssid escaping)
> > 
> 
> %pE<FLAGS> would allow the same arbitrary combinations
> of your flags.

Makes sense. 
Can do this as a separate patch.
Though I would have a sane default for escaping SSIDs. I hope that one
from print_ssid() could be the one.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/