Re: [PATCH 4/5] ARM: dts: AM437x: Add TPS65218 device tree nodes

[Felipe Balbi]

On Thu, Jul 03, 2014 at 07:15:01PM +0530, Keerthy wrote:
> Add TPS65218 device tree nodes.
> 
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> ---
>  arch/arm/boot/dts/am437x-gp-evm.dts |   38 +++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
> index 003766c..fc35d24 100644
> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
> @@ -260,6 +260,44 @@
>          status = "okay";
>          pinctrl-names = "default";
>          pinctrl-0 = <&i2c0_pins>;
> +	clock-frequency = <400000>;

same as before, also indentation is wrong, but I see indentation was
already wrong on this file, perhaps add a patch before this one fixing
that so this file is indented with tabs only ?

> +
> +	tps65218: tps65218@24 {
> +		reg = <0x24>;
> +		compatible = "ti,tps65218";
> +		interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
> +		interrupt-parent = <&gic>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +
> +		dcdc1: regulator-dcdc1 {
> +			compatible = "ti,tps65218-dcdc1";
> +			/* VDD_CORE voltage limits min of OPP50 and max of OPP100 */
> +			regulator-name = "vdd_core";
> +			regulator-min-microvolt = <912000>;
> +			regulator-max-microvolt = <1144000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		dcdc2: regulator-dcdc2 {
> +			compatible = "ti,tps65218-dcdc2";
> +			/* VDD_MPU voltage limits min of OPP50 and max of OPP_NITRO */
> +			regulator-name = "vdd_mpu";
> +			regulator-min-microvolt = <912000>;
> +			regulator-max-microvolt = <1378000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};

also missing dcdc3/4/5. (6 has a non-populated 0 ohm resistor, so it
should be turned off).

> +		ldo1: regulator-ldo1 {
> +			compatible = "ti,tps65218-ldo1";
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <1800000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +	};
>  };
>  
>  &i2c1 {
> -- 
> 1.7.9.5
> 

-- 
balbi

Attachment: signature.asc
Description: Digital signature