Re: [PATCH] mm readahead: Fix sys_readahead breakage by reverting 2MB limit (bug 79111)

[Raghavendra K T]

On 07/03/2014 09:11 PM, Linus Torvalds wrote:
> On Thu, Jul 3, 2014 at 6:02 AM, Raghavendra K T
> <raghavendra.kt@xxxxxxxxxxxxxxxxxx> wrote:
> > However it broke sys_readahead semantics: 'readahead() blocks until the specified
> > data has been read'
>
> What? Where did you find that insane sentence? And where did you find
> an application that depends on that totally insane semantics that sure
> as hell was never intentional.
>
> If this comes from some man-page,

Yes it is.

then the man-page is just full of
> sh*t, and is being crazy. The whole and *only* point of readahead() is
> that it does *not* block, and you can do it across multiple files.

Entirely agree. Infact I also had the strong opinion that we should
rather change man page instead of making Linux performing badly by doing
large unnecessary readahead when there is no actual read, and
performance numbers have proved that.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/