Re: [PATCH v2] platform_get_irq: Revert to platform_get_resource if of_irq_get fails
From: Guenter Roeck
Date: Fri Jul 04 2014 - 15:51:19 EST
On 06/30/2014 09:22 AM, Greg Kroah-Hartman wrote:
On Mon, Jun 30, 2014 at 09:18:35AM -0700, Guenter Roeck wrote:
On Mon, Jun 23, 2014 at 10:48:33AM -0500, Rob Herring wrote:
On Tue, Jun 17, 2014 at 5:51 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
Commits 9ec36ca (of/irq: do irq resolution in platform_get_irq)
and ad69674 (of/irq: do irq resolution in platform_get_irq_byname)
change the semantics of platform_get_irq and platform_get_irq_byname
to always rely on devicetree information if devicetree is enabled
and if a devicetree node is attached to the device. The functions
now return an error if the devicetree data does not include interrupt
information, even if the information is available as platform resource
data.
This causes mfd client drivers to fail if the interrupt number is
passed via platform resources. Therefore, if of_irq_get fails, try
platform_get_resource as method of last resort. This restores the
original functionality for drivers depending on platform resources
to get irq information.
Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>
Cc: Tony Lindgren <tony@xxxxxxxxxxx>
Cc: Grant Likely <grant.likely@xxxxxxxxxx>
Cc: Grygorii Strashko <grygorii.strashko@xxxxxx>
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Acked-by: Rob Herring <robh@xxxxxxxxxx>
Greg should take this for 3.16.
Doesn't seem to go anywhere. Guess it's one more patch I'll have to carry
locally :-(. If anyone has a better idea how to fix the problem, please
let me know.
I can still queue this up, I was hoping that Grant would chime in...
Doesn't look like it.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/