Re: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug

[Joe Perches]

On Sun, 2014-07-06 at 18:32 +0200, Fabio Falzoi wrote:
> Have I to fix just the commit message or is this behaviour not suitable?
> In the latter case, could you please suggest a way to fix this?

Hi Fabio.

I think it's not appropriate.
I'd've changed it to something like:

#if DEBUG
#define rtsx_hex_dump(buf, len)						\
	print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE,	\
			     buf, len)
#else
#define rtsx_hex_dump(buf, len)
	do {;} while (0)
#endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/