Re: [PATCH] staging: iio: Introduce the use of devm_ioremap_resource

From: Lars-Peter Clausen
Date: Mon Jul 07 2014 - 08:36:31 EST


On 07/07/2014 02:36 PM, Jonathan Cameron wrote:
On 01/07/14 19:44, Himangi Saraogi wrote:
This patch introduces the use of devm_ioremap_resource. It does away
with call to request_mem_region and the error checking on
platform_get_resource. Also, the calls to free the allocated resources
like release_mem_region and iounmap are done away with. The ret variable
in the probe function is also eliminated. Also, a bug is fixed as the
goto in the error handling of request_mem_region should not have
called release_mem_region which releases a resource that has not been
allocated.

Signed-off-by: Himangi Saraogi <himangi774@xxxxxxxxx>
Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
Again, looks superficially fine, but I'd like an ack from someone
at Analog ideally.
Cc'd Lars

Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/