Re: [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe

From: Jiri Kosina
Date: Mon Jul 07 2014 - 09:05:57 EST


On Mon, 7 Jul 2014, One Thousand Gnomes wrote:

> > This removes the sizeof(frame) from the call to get_sigframe on line
> > 243 in order to fix the call to this function as the sizeof in not
> > needed to call this function.
>
> If you are going to submit patches then
>
> - actually read what you are submitting
>
> - check it actually compiles
>
> - run it on the system in question and verify your changed code paths are
> used
>
> *then* consider submitting it, otherwise all you are doing is wasting
> people's time.

Seconded. Nicholas, this is a third time I've seen patch from you in my
mailbox that didn't make any sense whatsoever. Please be more careful,
once certain reputation is gained, it's very difficult to escape it.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/